remove /projects/ #6228
remove /projects/ #6228
Conversation
|
Thanks for the pull request!
I'd say that section can go too. Looks like it links from https://readthedocs.org/projects/docs/ (the tags section) https://readthedocs.org/projects/docs/ Maybe @davidfischer has another opinion here But if the section stays, you shouldn't remove the template, as that view still uses it. |
|
Sorry, wrong button |
|
Okay, thanks - I'll wait for input from @davidfischer before I make any further updates. |
At least right now I don't think we should remove browsing projects by tag (eg. https://readthedocs.org/projects/tags/python/). Compared with listing all projects, at least tags have a use which is finding similar projects. I also wouldn't mind if |
|
Okay, thanks. In that case, I think my course of action is to reinstate the template I removed and all should be well. |
|
@iambenzo can you please merge master into this branch? Test on travis have been fixed |
|
Sure thing. |
iambenzo
force-pushed
the
remove-projects-page
branch
from
f172382 to
8ce612e
Compare
|
We can now remove this conditional, as we always expect a tag now, and probably rename the class |
|
Okie dokie - I'll get on that a little later |
| @@ -37,7 +37,7 @@ | |||
| mimetypes.add_type('application/epub+zip', '.epub') | |||
|
|
|||
|
|
|||
| class ProjectIndex(ListView): | |||
| class ProjectTagIndex(ListView): | |||
There was a problem hiding this comment.
I'm just noting that this change will require a corresponding change to the private Read the Docs corporate repository.
| else: | ||
| self.tag = None | ||
| self.tag = get_object_or_404(Tag, slug=self.kwargs.get('tag')) | ||
| queryset = queryset.filter(tags__slug__in=[self.tag.slug]) | ||
|
|
||
| if self.kwargs.get('username'): |
There was a problem hiding this comment.
It doesn't seem like this is used anymore. As a separate change in a separate PR, this could probably be removed.
Fixes #6221
I am relatively new to development with Django but to remove the publicly accessible
/projectspath, only a small amount of removals seemed to be required.I did not remove the ProjectIndex class, as it seems that the tags functionality is dependant on it. If you're happy for the tags to go, I will be happy to update my PR.
I did not remove the project_urls section, as clicking on a project as a logged in user takes you to a
/projects/<project_name>route.Please let me know how I did in meeting your expectations and let me know if I can do any better.